Re: [AC21.5R21.4] [CORE (21.5)] Ever-so-slightly prettier `report-xemacs-bug'
- First Post
- Replies
- Stats
-
Go to
- ----- 2024 -----
- April
- March
- February
- January
- ----- 2023 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2022 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2021 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2020 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2019 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2018 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2017 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2016 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2015 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2014 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2013 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2012 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2011 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2010 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2009 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2008 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2007 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2006 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2005 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2004 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2003 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2002 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2001 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 2000 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1999 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
- February
- January
- ----- 1998 -----
- December
- November
- October
- September
- August
- July
- June
- May
- April
- March
QUERY
No need to revert, but this should be discussed.
>>>> "SY" == Steve Youngs
<youngs(a)xemacs.org> writes:
+ * cl-extra.el (cl-do-prettyprint): Work around a "formatting" bug
+ in `report-xemacs-bug'.
Strictly speaking this isn't a workaround, it fixes a parsing bug in
cl-do-prettyprint.
+ (let ((skip (or (looking-at "((")
+ (looking-at "(prog[nv12\\(ress-feedback\\|n-with-message\\)]")
`progress-feedback' is not a control structure, so I don't think it
belongs in here.
Ie, normally progress-feedback and its argument are going to appear on
one line, and when they don't, they should appear as
(progress-feedback
"format-string")
not
(progress-feedback
"format-string")
Opinions?
--
Institute of Policy and Planning Sciences http://turnbull.sk.tsukuba.ac.jp
University of Tsukuba Tennodai 1-1-1 Tsukuba 305-8573 JAPAN
Ask not how you can "do" free software business;
ask what your business can "do for" free software.
Steve Youngs
Wednesday, 1 October
Wed, 1 Oct
10:15 a.m.
New subject: [AC21.5R21.4] [CORE (21.5)] Ever-so-slightly prettier `report-xemacs-bug'
|--==> "SJT" == Stephen J Turnbull <stephen(a)xemacs.org> writes:
SJT> QUERY
SJT> No need to revert, but this should be discussed.
>>>>>"SY" == Steve Youngs
<youngs(a)xemacs.org> writes:
SJT> + * cl-extra.el (cl-do-prettyprint): Work around a "formatting" bug
SJT> + in `report-xemacs-bug'.
SJT> Strictly speaking this isn't a workaround, it fixes a parsing bug in
SJT> cl-do-prettyprint.
SJT> + (let ((skip (or (looking-at "((")
SJT> + (looking-at
"(prog[nv12\\(ress-feedback\\|n-with-message\\)]")
SJT> `progress-feedback' is not a control structure, so I don't think it
SJT> belongs in here.
[...]
SJT> Opinions?
I have no problem with losing the 'ress-feedback', just say the word
and it's history.
--
|---<Steve Youngs>---------------<GnuPG KeyID: 10D5C9C5>---|
| XEmacs - The only _______ you'll ever need. |
| Fill in the blank, yes, it's THAT good! |
|------------------------------------<youngs(a)xemacs.org>---|
John Paul Wallington
Wednesday, 1 October
Wed, 1 Oct
11:40 a.m.
New subject: [AC21.5R21.4] [CORE (21.5)] Ever-so-slightly prettier `report-xemacs-bug'
"Stephen J. Turnbull" <stephen(a)xemacs.org> wrote:
+ * cl-extra.el (cl-do-prettyprint): Work around a
"formatting" bug
+ in `report-xemacs-bug'.
Strictly speaking this isn't a workaround, it fixes a parsing bug in
cl-do-prettyprint.
+ (let ((skip (or (looking-at "((")
+ (looking-at "(prog[nv12\\(ress-feedback\\|n-with-message\\)]")
[...]
Opinions?
Making `cl-do-prettyprint' more specific looks good. How about using
`pp' or `insert' and `pp-to-string' instead for the Packages output ?
7510
days inactive
7510
days old
2 comments
3 participants
tags (0)
participants (3)
-
John Paul Wallington -
Stephen J. Turnbull -
Steve Youngs