Re: (insert 8000) crashes XEmacs 21.2.16

older

Re: URL loading library?

xterm mouse support... kindof...

SL Baur

Monday, 21 June 1999 Mon, 21 Jun '99

9:19 a.m.

(permalink)

Yoshiki Hayashi <t90553(a)m.ecc.u-tokyo.ac.jp> writes in xemacs-beta(a)xemacs.org:

...

xemacs -vanilla (insert 8000)

Ouch! -- 窓番号を入力してください

Show replies by thread

Yoshiki Hayashi

Monday, 8 November Mon, 8 Nov

8:39 a.m.

(permalink)

New subject: (insert 8000) crashes XEmacs 21.2.16

SL Baur <steve(a)xemacs.org> writes:

...

Yoshiki Hayashi <t90553(a)m.ecc.u-tokyo.ac.jp> writes in xemacs-beta(a)xemacs.org: > xemacs -vanilla > (insert 8000) Ouch!

I finally traced this bug and fixed it. Integer 8000 is in the range of private charset. It is usually not defined, so every integer around 8000 can cause core dump. XEmacs 21.1 doesn't crash since it does not usually have error checking code. However, this patch is recommended for XEmacs 21.1 as it goes to hard uninterruptible loop with (insert 8000). 1999-11-08 Yoshiki Hayashi <t90553(a)mail.ecc.u-tokyo.ac.jp> * mule-charset.h (breakup_char_1): Check whether charset exists or not. -- Yoshiki Hayashi

Ben Wing

Tuesday, 9 November Tue, 9 Nov

4:13 a.m.

(permalink)

New subject: (insert 8000) crashes XEmacs 21.2.16

Veto. Instead, fix buffer_insert_1() and Finsert_markers() -- they need a call to CHECK_CHAR_COERCE_INT() inserted. Yoshiki Hayashi wrote:

...

SL Baur <steve(a)xemacs.org> writes: > Yoshiki Hayashi <t90553(a)m.ecc.u-tokyo.ac.jp> writes in xemacs-beta(a)xemacs.org: > > > xemacs -vanilla > > (insert 8000) > > Ouch! I finally traced this bug and fixed it. Integer 8000 is in the range of private charset. It is usually not defined, so every integer around 8000 can cause core dump. XEmacs 21.1 doesn't crash since it does not usually have error checking code. However, this patch is recommended for XEmacs 21.1 as it goes to hard uninterruptible loop with (insert 8000). 1999-11-08 Yoshiki Hayashi <t90553(a)mail.ecc.u-tokyo.ac.jp> * mule-charset.h (breakup_char_1): Check whether charset exists or not. ------------------------------------------------------------------------ Name: mule-charset.h.diff mule-charset.h.diff Type: Plain Text (text/plain) Encoding: 7bit ------------------------------------------------------------------------ -- Yoshiki Hayashi

Yoshiki Hayashi

Tuesday, 9 November Tue, 9 Nov

6:33 a.m.

(permalink)

New subject: (insert 8000) crashes XEmacs 21.2.16

Ben Wing <ben(a)666.com> writes:

...

Veto. Instead, fix buffer_insert_1() and Finsert_markers() -- they need a call to CHECK_CHAR_COERCE_INT() inserted.

Thanks. I found bug in Finsert_char and others. It calls CHECK_CHAR_COERCE_INT but it is not sufficient. Its definition is #define CHECK_CHAR_COERCE_INT(x) do { \ if (CHARP (x)) \ ; \ else if (CHAR_INTP (x)) \ x = make_char (XINT (x)); \ else \ x = wrong_type_argument (Qcharacterp, x); \ } while (0) so it accepts integer as an argument. (insert-char ?8000) is OK while (insert-char 8000) makes XEmacs crash. It should reject integer argument, right? Other function which call CHECK_CHAR_COERCE_INT is also broken. For example, you can crash XEmacs with (make-string 1 8000). How should I fix this? Should I change CHECK_CHAR_COERCE_INT not to accept integer or make new macro CHECK_CHAR_COERCE which doesn't accept integer? BTW, I couldn't find Finsert_markers. I found Finsert_before_markers but it just calls buffer_insert_1 when argument is char or int. So it's OK when we fix buffer_insert_1. -- Yoshiki Hayashi

Kyle Jones

Tuesday, 9 November Tue, 9 Nov

7:09 a.m.

(permalink)

New subject: (insert 8000) crashes XEmacs 21.2.16

So far on xemacs-beta the current plan is to make Finsert (and presumably any other buffer insertion function that accepts chars) signal wrong-type-argument when presented with an integer. As for the ?\ooo read syntax, \ooo should be allowed for \000-\377. It should fail with some kind of read syntax error for anything over 0377. This keep compatbility with 8-bit XEmacs, and doens't break the abstraction layer for whatever the wide char turns out to be.

8929

days inactive

9070

days old

xemacs-beta@xemacs.org

Manage subscription

4 comments

4 participants

tags (0)

participants (4)

Ben Wing
Kyle Jones
SL Baur
Yoshiki Hayashi

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

2000

1999

1998

Re: (insert 8000) crashes XEmacs 21.2.16