Re: latest CVS does not compile, and patches question
At 12:54 PM 9/1/99 +0200, Stef Epardaud wrote:
latest CVS does not compile for me, very related to that:
../lwlib/liblw.a(xlwradio.o): In function `RadioSize':
/usr/local/src/xemacs-cvs/xemacs/lwlib/xlwradio.c:535: undefined
reference to `Max'
../lwlib/liblw.a(xlwgauge.o): In function `GaugeSize':
/usr/local/src/xemacs-cvs/xemacs/lwlib/xlwgauge.c:1021: undefined
reference to `Max'
/usr/local/src/xemacs-cvs/xemacs/lwlib/xlwgauge.c:1027: undefined
reference to `Max'
/usr/local/src/xemacs-cvs/xemacs/lwlib/xlwgauge.c:968: undefined
reference to `Max'
/usr/local/src/xemacs-cvs/xemacs/lwlib/xlwgauge.c:1054: undefined
reference to `Max'
../lwlib/liblw.a(xlwgauge.o):/usr/local/src/xemacs-cvs/xemacs/lwlib/xlwgaug
e.c:1060:
more undefined references to `Max' follow
Ug, I forgot to commit xmu.h. Fixed now.
but it raises yet another question: i see loads of patches around
here,
some more in xemacs-patches, but not all make it into CVS, and some are
_dropped_ and some other are put on top of some others....
so, what should i do? apply a patch everytime i need it, or wait for one
of you guys to put in into CVS.
In general if you have cvs then wait for cvs. cvs is the official version.
cvs should not lag most patches by much.
what should we do with all those patches, really?
Primarily, review them. The patches give people visibility of what is going
into cvs and an opportunity to stop them or pre-test them.
andy
--------------------------------------------------------------
Dr Andy Piper
Senior Consultant Architect, BEA Systems Ltd